Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better Tests #2

Closed
davorg opened this issue Oct 5, 2016 · 1 comment
Closed

Better Tests #2

davorg opened this issue Oct 5, 2016 · 1 comment
Labels
enhancement hacktoberfest

Comments

@davorg
Copy link
Collaborator

davorg commented Oct 5, 2016

The tests are very much of the time they were written (or, perhaps, of my level of knowledge at the time they were written). There's a lot of stuff like ok(&sub eq 'string') which sohld be changed to is(sub(), 'string').

Also we should get rid of the explicit plans and use done_testing().
@davorg
Copy link
Collaborator Author

davorg commented Oct 6, 2016

Done in #9

@davorg davorg closed this as completed Oct 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davorg