Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qcustomplot 2.1 compatibility #178

Closed
mirabilos opened this issue Nov 8, 2022 · 4 comments
Closed

qcustomplot 2.1 compatibility #178

mirabilos opened this issue Nov 8, 2022 · 4 comments

Comments

@mirabilos
Copy link
Contributor

Hi,

the Debian maintainer of qcustomplot approached me about transitioning Polyphone to the new version 2.1 of it.

The patch needed for this is minimal, it basically changes -lqcustomplot to -lQCustomPlot (he verified that it at least built fine with just this change). We probably should support both and have the .pro file check which one to use, but my qmake skills are basically nōnexistent.

However, I need to test this. Where is this actually used in Polyphone and how can I test that nothing breaks?

@rikmills
Copy link

rikmills commented Dec 4, 2022

Polyphone now marked for autoremoval from Debian on 13th December. Ubuntu likely to follow.

https://tracker.debian.org/pkg/polyphone

@mirabilos
Copy link
Contributor Author

mirabilos commented Dec 4, 2022 via email

@mirabilos
Copy link
Contributor Author

I’ve now uploaded a hack to Debian to avoid it getting removed. It will now build with v2.1 but not v2.0 of the library, so the patch is not upstreamable as-is but someone who knows qmake can easily produce something suitable.

I’ve also not received any response regarding how to test whether the change will still result in a good application. Someone™ should install polyphone (= 2.2.0.20210109+dfsg1-3) from Debian unstable once it’s built and test that.

@davy7125
Copy link
Owner

No more qcustomplot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants