Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📓adding contribution doc #214

Merged
merged 8 commits into from
May 8, 2023
Merged

Conversation

jtfirek
Copy link
Collaborator

@jtfirek jtfirek commented Apr 24, 2023

@dawsbot, Thoughts on this? I moved the gitPoap info over to the contribution page. Solves #209

readme.md Outdated
@@ -956,26 +382,6 @@ weiToEther(1000000000000000000000).toNumber();
zeroPad(value: BytesLike, length: number): Uint8Array
```

<details>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtfirek this readme auto-deleting stuff is pretty frustrating, sorry I introduced that in the PR's yesterday. If you could checkout master for this file then make your changes carefully and do a git commit --no-verify it will be uploaded here properly

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dawsbot, added the auto-deleted text back!

@jtfirek
Copy link
Collaborator Author

jtfirek commented Apr 25, 2023

@dawsbot
Copy link
Owner

dawsbot commented May 2, 2023

@dawsbot, I am not sure how to define what the 🧪 means for the doc: https://github.com/jtfirek/essential-eth/blob/1f37fcbc3be814a03a9249baea9292307cee750c/CONTRIBUTING.md?plain=1#L5-L11

Just add "🧪: Tests"

I don't understand your question, please elaborate

@jtfirek
Copy link
Collaborator Author

jtfirek commented May 3, 2023

@dawsbot, I am not sure how to define what the 🧪 means for the doc: https://github.com/jtfirek/essential-eth/blob/1f37fcbc3be814a03a9249baea9292307cee750c/CONTRIBUTING.md?plain=1#L5-L11

Just add "🧪: Tests"

I don't understand your question, please elaborate

This is all I needed to know. I was just asking for the exact definition of 🧪 so I could add it to the contribution doc.

@jtfirek
Copy link
Collaborator Author

jtfirek commented May 3, 2023

This is ready for review now @dawsbot !

@dawsbot dawsbot merged commit 69cec04 into dawsbot:master May 8, 2023
@jtfirek jtfirek deleted the adding-contributing-doc branch May 8, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants