-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📓adding contribution doc #214
Conversation
readme.md
Outdated
@@ -956,26 +382,6 @@ weiToEther(1000000000000000000000).toNumber(); | |||
zeroPad(value: BytesLike, length: number): Uint8Array | |||
``` | |||
|
|||
<details> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jtfirek this readme auto-deleting stuff is pretty frustrating, sorry I introduced that in the PR's yesterday. If you could checkout master for this file then make your changes carefully and do a git commit --no-verify
it will be uploaded here properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dawsbot, added the auto-deleted text back!
023c80d
to
beed549
Compare
@dawsbot, I am not sure how to define what the 🧪 means for the doc: |
Just add "🧪: Tests" I don't understand your question, please elaborate |
This is all I needed to know. I was just asking for the exact definition of 🧪 so I could add it to the contribution doc. |
This is ready for review now @dawsbot ! |
@dawsbot, Thoughts on this? I moved the gitPoap info over to the contribution page. Solves #209