-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement]: Path inspector left and right-click suggestions #348
Comments
The tasks from this issue are:
|
@MawiraIke I've updated the spec for item 2 above ^^^ Note: we're skipping the "history of paths with step back and forward functionalities" feature |
Nice improvements. Love the parent path and clear path buttons. Some feedback:
|
Thanks @Gregg8 for the feedback. The issues you mentioned above are in continuous development and the second one regarding middle click triggering scroll mode should be fixed in the latest release 1.2.4. |
@Gregg8 the remaining two issues should be fixed on PR #356 waiting to be merged.
|
Added mouse-offset parameters. Now, the menu appears at the exact mouse position. I'm not sure what the importance of popup-menus is. Maybe it's just a kind of render memoization, build-popup doesn't seem expensive enough to justify it. Removed this pattern. Such memoization doesn't really work here, since the new mouse-offset tends to be a different value every time. #348
Added mouse-offset parameters. Now, the menu appears at the exact mouse position. I'm not sure what the importance of popup-menus is. Maybe it's just a kind of render memoization, but build-popup doesn't seem expensive enough to justify it. Removed this pattern. Such memoization doesn't really work here, since the new mouse-offset tends to be a different value every time. #348
Added mouse-offset parameters. Now, the menu appears at the exact mouse position. I'm not sure what the importance of popup-menus is. Maybe it's just a kind of render memoization, but build-popup doesn't seem expensive enough to justify it. Removed this pattern. Such memoization doesn't really work here, since the new mouse-offset tends to be a different value every time. #348
1 - Right-click menu improvements
Suggestions:
2 - New path replaces current path
It's quite jarring to have the parent tree disappear when you click on items.
After some discussions, we've decided on four functions that should cover all use cases:
Open path in current inspector
Open path in NEW inspector
Open parent path in current inspector
md-icon-button
next to the pathinput-text
[]
Clear inspector path
md-icon-button
next to the pathinput-text
See the screenshot below for button placement:
The text was updated successfully, but these errors were encountered: