Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve popups and, path generation in sets and non-map objects #350

Merged
merged 5 commits into from
Mar 4, 2022

Conversation

MawiraIke
Copy link
Contributor

@MawiraIke MawiraIke commented Feb 21, 2022

This PR fixes the following issues

  • Use a real popup instead of the embedded popup currently used
  • Fixes incorrect path generation in nested objects
  • Fixes incorrect path generation in sets
  • Fix current path erasure when path is copied from the Menu

See #347 and #348

@MawiraIke
Copy link
Contributor Author

Note: This PR will work as intended with the current devtools version but will need to have this commit in devtools merged before paths in sets and nested objects are displayed perfectly.

@MawiraIke MawiraIke changed the title Improve popups and, path generation in sets and maps Improve popups and, path generation in sets and non-map objects Feb 21, 2022
@superstructor superstructor self-requested a review March 4, 2022 02:49
@superstructor superstructor merged commit 73dac1d into day8:master Mar 4, 2022
@MawiraIke MawiraIke deleted the enhancement/path-annotations branch April 14, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants