Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SVG handling in Firefox #130

Closed
danielcompton opened this issue Jan 12, 2018 · 2 comments
Closed

Fix SVG handling in Firefox #130

danielcompton opened this issue Jan 12, 2018 · 2 comments

Comments

@danielcompton
Copy link
Contributor

Firefox doesn't load our inline SVG images if they have a hex colour fill property on the path. We need to figure out how to avoid this.
@smee
Copy link
Contributor

smee commented Jan 25, 2018

The problem seems to be the # character. It needs to be url encoded, so a simple replace with %23 does the trick. Doing so manually in the element inspector leads to a correct rendering of the icons.

@danielcompton
Copy link
Contributor Author

Thanks, that's very helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smee @danielcompton