-
-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error with infer-externs "goog is not defined in the externs" #512
Labels
Comments
Just to clarify, you're saying it looks like the issue is the leading |
Yes, seems to be.
|
@olivergeorge any chance you could provide a PR for the fix you see as working? |
Gladly. Before I do I need an idiom check on |
Fixed via #517 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've turned on :infer-externs and now get a warning doing an advanced optimisations build:
Pretty sure this is caused by the way goog.DEBUG is referred to in the re-frame.interop namespace
My testing of infer-externs shows this:
The text was updated successfully, but these errors were encountered: