Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Has an issue in StrictMode #4

Closed
embeddedt opened this issue Nov 14, 2019 · 1 comment
Closed

Has an issue in StrictMode #4

embeddedt opened this issue Nov 14, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@embeddedt
Copy link

embeddedt commented Nov 14, 2019

I've found that this library generates an error when used with React's strict mode. It looks like it would be straightforward to fix - this code just needs to be switched to using refs instead of using findDOMNode.

Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of Styler which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://fb.me/react-strict-mode-find-node
    in div (created by Styler)
    in Styler (created by MoveableManager)
    in MoveableManager (created by Moveable)
    in Moveable
@daybrush daybrush added the bug Something isn't working label Dec 29, 2019
@daybrush
Copy link
Owner

@embeddedt

Thank you for reporting react bug and sorry to see this issue now.

I will fix this problem soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants