Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.2 Warning for count() in libraries/Menu.php #519

Open
kevindeleon opened this issue Nov 20, 2018 · 3 comments
Open

PHP 7.2 Warning for count() in libraries/Menu.php #519

kevindeleon opened this issue Nov 20, 2018 · 3 comments

Comments

@kevindeleon
Copy link

kevindeleon commented Nov 20, 2018

On a fresh 1.4 install on PHP 7.2 using the develop branch, on any admin area that has the "Tree" view -- receiving the following PHP Warning -- Message: count(): Parameter must be an array or an object that implements Countable | Filename: libraries/Menu.php | Line Number: 450

You can reproduce by simply going to the "Permissions" menu item (/fuel/permissions) and clicking "Tree" from the view layout options.

Can also be reproduced in any of the menu items in the admin that support the "Tree" view (Pages, etc).

If there are no items (like there are no pages on a fresh install) then obviously there are no errors.

daylightstudio pushed a commit that referenced this issue Nov 20, 2018
@martynassateika
Copy link
Contributor

Similar issue on line 1064 in the same file Menu.php: #498

@daylightstudio
Copy link
Owner

Is this with 1.4.3? I believe those issues were fixed.

@martynassateika
Copy link
Contributor

Hey David, congrats on the release of 1.4.3! I will try and reproduce the bug, and will update #498.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants