-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate repo validation #791
Remove duplicate repo validation #791
Conversation
…ytonaio#550)" (daytonaio#773) This reverts commit 2c02b17. Signed-off-by: Abhishek Kumar Gupta <abhishekguptaatweb17@gmail.com>
7fc2a69
to
1d4b851
Compare
Up for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on the removal of your own code 😅
Address the one comment and we should be good to go.
Also, please edit the commit message to include a subject (e.g. feat: allow duplicate repo entries as projects
) and edit the PR description.
Signed-off-by: Abhishek Kumar Gupta <abhishekguptaatweb17@gmail.com>
Signed-off-by: Abhishek Kumar Gupta <abhishekguptaatweb17@gmail.com>
1d4b851
to
1ca3b47
Compare
Up for review! ps: do consider a tip, these are small issues but takes some effort especially for rework on review comments 😅 |
Reworking the PR based on review comments is not something that should influence the perceived effort for the solution (unless the comments change the direction of the issue). Hope you understand that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are great now for the TUI view but the projects still have the same name when running daytona create --multi-project --manual
0cbf9f0
to
f27575c
Compare
fixed for manual, Up for review! |
Signed-off-by: Abhishek Kumar Gupta <abhishekguptaatweb17@gmail.com>
f27575c
to
10b22be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @abhishek818 - just some minor comments
Signed-off-by: Abhishek Kumar Gupta <abhishekguptaatweb17@gmail.com>
5b8f722
to
a7779d7
Compare
Up for review! |
Signed-off-by: Abhishek Kumar Gupta <abhishekguptaatweb17@gmail.com> Signed-off-by: johnwick <jiosupprt270@gmail.com>
Remove duplicate repo validation #773
Description
Remove duplicate repo validation and append occurence number to keep duplicate entries unique.
Related Issue(s)
This PR addresses issue #773
closes #773
/claim #773
Screenshots
Notes