Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate repo validation #791

Merged
merged 5 commits into from
Jul 30, 2024

Conversation

abhishek818
Copy link
Contributor

@abhishek818 abhishek818 commented Jul 17, 2024

Remove duplicate repo validation #773

Description

Remove duplicate repo validation and append occurence number to keep duplicate entries unique.

  • This change requires a documentation update
  • I have made corresponding changes to the documentation

Related Issue(s)

This PR addresses issue #773
closes #773
/claim #773

Screenshots

Notes

…ytonaio#550)" (daytonaio#773)

This reverts commit 2c02b17.

Signed-off-by: Abhishek Kumar Gupta <abhishekguptaatweb17@gmail.com>
@abhishek818 abhishek818 force-pushed the remove_duplicate_repo_validation branch from 7fc2a69 to 1d4b851 Compare July 20, 2024 21:00
@abhishek818 abhishek818 marked this pull request as ready for review July 20, 2024 21:01
@abhishek818 abhishek818 requested a review from a team as a code owner July 20, 2024 21:01
@abhishek818
Copy link
Contributor Author

Up for review!

Copy link
Member

@Tpuljak Tpuljak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on the removal of your own code 😅

Address the one comment and we should be good to go.

Also, please edit the commit message to include a subject (e.g. feat: allow duplicate repo entries as projects) and edit the PR description.

pkg/cmd/workspace/create.go Outdated Show resolved Hide resolved
Signed-off-by: Abhishek Kumar Gupta <abhishekguptaatweb17@gmail.com>
Signed-off-by: Abhishek Kumar Gupta <abhishekguptaatweb17@gmail.com>
@abhishek818 abhishek818 force-pushed the remove_duplicate_repo_validation branch from 1d4b851 to 1ca3b47 Compare July 25, 2024 21:24
@abhishek818
Copy link
Contributor Author

Up for review!

ps: do consider a tip, these are small issues but takes some effort especially for rework on review comments 😅

@abhishek818 abhishek818 requested a review from Tpuljak July 25, 2024 21:28
@Tpuljak
Copy link
Member

Tpuljak commented Jul 26, 2024

especially for rework on review comments

Reworking the PR based on review comments is not something that should influence the perceived effort for the solution (unless the comments change the direction of the issue). Hope you understand that.

Copy link
Member

@Tpuljak Tpuljak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are great now for the TUI view but the projects still have the same name when running daytona create --multi-project --manual

@abhishek818 abhishek818 force-pushed the remove_duplicate_repo_validation branch from 0cbf9f0 to f27575c Compare July 26, 2024 15:26
@abhishek818
Copy link
Contributor Author

fixed for manual, Up for review!

Signed-off-by: Abhishek Kumar Gupta <abhishekguptaatweb17@gmail.com>
@abhishek818 abhishek818 force-pushed the remove_duplicate_repo_validation branch from f27575c to 10b22be Compare July 26, 2024 15:28
@abhishek818 abhishek818 requested a review from Tpuljak July 26, 2024 15:28
Copy link
Member

@Tpuljak Tpuljak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@Tpuljak Tpuljak requested a review from idagelic July 29, 2024 07:10
idagelic
idagelic approved these changes Jul 29, 2024
pkg/cmd/workspace/create.go Outdated Show resolved Hide resolved
pkg/cmd/workspace/create.go Outdated Show resolved Hide resolved
pkg/cmd/workspace/util/creation_data.go Show resolved Hide resolved
@idagelic idagelic self-requested a review July 29, 2024 14:10
Copy link
Member

@idagelic idagelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abhishek818 - just some minor comments

Signed-off-by: Abhishek Kumar Gupta <abhishekguptaatweb17@gmail.com>
@abhishek818 abhishek818 force-pushed the remove_duplicate_repo_validation branch from 5b8f722 to a7779d7 Compare July 30, 2024 10:57
@abhishek818
Copy link
Contributor Author

Up for review!

@idagelic idagelic merged commit 5dee98a into daytonaio:main Jul 30, 2024
12 checks passed
the-johnwick pushed a commit to the-johnwick/daytona that referenced this pull request Aug 13, 2024
Signed-off-by: Abhishek Kumar Gupta <abhishekguptaatweb17@gmail.com>
Signed-off-by: johnwick <jiosupprt270@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow duplicate repositories in a single workspace
3 participants