Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution Nuget Package version number - allow it to be set explicitly #12

Closed
dazinator opened this issue May 2, 2015 · 2 comments
Closed

Comments

@dazinator
Copy link
Owner

At the moment, BuildVersionNumber is used for the last digit of both:

  1. The individual module nuget packages (if you are producing those)
  2. The solution level nuget package version number (if you are producing that)

However for 1) - its assumed to be a integer and is appended as a 4th segment, to the existing 3 segment version in the module manifest - to produce a valid 4 segment nuget package version number.

But for 2) it's just used as is, in which case a single digit number isn;t a valid NuGet package version - so attempting to produce a solution nuget package won;t work unless you pass in a BuildVersionNumber like 1.0.1 or something valid.

Rather than using the 'BuildVersionNumber' for both those scenarios, I'm going to change it so that the BuildVersionNumber is only used for 1)

I will introduce a seperate msbuild property that must be set in order to control the solution level nuget deployment pacakge version number.

Run the following to replicate the problem - i.e 12345 isn't valid for the NuGet solution package version number

msbuild "G:\Test.sln" /p:CreateSolutionDeploymentPackage=true /p:NuGetExeFilePath="packages\NuGet.CommandLine.2.8.2\tools\NuGet.exe" /p:BuildVersionNumber=12345
@dazinator dazinator added the bug label May 2, 2015
@dazinator
Copy link
Owner Author

This "Solution NuGet Package" feature is currently on hold whilst #15 is done.
I might look to remove this feature in v2 and then re-implement it in a nicer way if anyone actually requires it.

@dazinator
Copy link
Owner Author

Decided to scrap this feature as there is an alternate way to achieve all this now.

DnnPackager v2 will still add a solution.nuspec file to your solution, to be helpful - and all you need to do is:

  1. Add the paths to your module zips to it that you want to be included in the nuget package.
  2. Call NuGet.Exe Pack on the NuSpec file.

This will produce you a NuGet package containing all of your installation zips for you to put on whatever nuget feed you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant