Skip to content
This repository has been archived by the owner on Apr 19, 2021. It is now read-only.

onChange doesn't behave as described in docs #27

Closed
0xsven opened this issue Aug 13, 2018 · 3 comments
Closed

onChange doesn't behave as described in docs #27

0xsven opened this issue Aug 13, 2018 · 3 comments

Comments

@0xsven
Copy link

0xsven commented Aug 13, 2018

Expected:
"Callback when visibility changes. Argument is a boolean, true for visible, false for not."

Actual:
Callback when scrolling and element in viewport. Argument is always true. Maybe rename it to onVisible or onScrollAndVisible (when bounce true).

Correction: It actually works when scrolling back up. So it checks if the viewport is below or above the element. But not if the element is in the viewport.

@dazld
Copy link
Owner

dazld commented Aug 13, 2018

that sounds like a bug - it should call with false when the element exits the viewport.

@animify
Copy link

animify commented Sep 2, 2018

Any update on this? Coming across the same issue

@dazld
Copy link
Owner

dazld commented Sep 23, 2018

sorry for delay @animify and @0xsven - this is fixed in 1.5.1 and should be available now :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants