Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: provide an option to disable icon's automatic margin-inline-end #356

Open
juthilo opened this issue Mar 6, 2023 · 0 comments

Comments

@juthilo
Copy link
Contributor

juthilo commented Mar 6, 2023

At the moment, all icons receive a small amount of right margin, which is very helpful when they're placed in front of text.

However, in some situations, there is no text afterwards and the margin causes a weird look. In Core, for icononly buttons and similar (but not all) use cases, there's styling to reset the margin to 0. This isn't applied in Elements though, because icons use the shadow DOM there.

I would love an additional attribute like data-icon-margin with values default | none or similar to enable users to remove margin whenever needed.

Opening issue in Core because the general option to remove margin might be relevant to many, regardless of framework. Let me know if I should open in Elements instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant