Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot find icon.png error on startup #74

Closed
rationalism opened this issue Dec 9, 2023 · 4 comments
Closed

Cannot find icon.png error on startup #74

rationalism opened this issue Dec 9, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@rationalism
Copy link

When trying to start the emulator using cargo run on the main branch (commit 23617a7500192f35a13ffd65539ef1171581a691), there's an error that it can't find the file icon.png. Moving icon.png from the install/ directory into the repo root directory fixes the issue.

@rationalism rationalism added the bug Something isn't working label Dec 9, 2023
@dbalsom
Copy link
Owner

dbalsom commented Dec 9, 2023

The intent is to run 'cargo run' from the install directory.
MartyPC needs several files (including the config) and i didn't want to clutter up the root of the repo.

@dbalsom
Copy link
Owner

dbalsom commented Dec 9, 2023

Going to close as this is covered in #70

@dbalsom dbalsom closed this as completed Dec 9, 2023
@rationalism
Copy link
Author

@dbalsom I ran cargo run from a fresh pull of the repo (on main) and saw the same error

@dbalsom
Copy link
Owner

dbalsom commented Dec 9, 2023

@dbalsom I ran cargo run from a fresh pull of the repo (on main) and saw the same error

cargo's job is to build an executable, and as long as 'cargo build' produces an executable, then everything is fine as far as I am concerned. I don't intend to recommend use of 'cargo run' as any official way to run MartyPC.

Your best bet is to run cargo build, then copy the martypc executable out of the target/release directory once built and copy it over the executable from the last official release, which should (hopefully) have a compatible config and directory tree.

Not finding the icon shouldn't be a critical error though, and I plan to address that. it's a bit of a kludge that I can't use the icon resource in the executable itself to set the window icon using winit, but that's another story.

Your point about needing better (or any) build documentation is valid, I will try to work on build instructions in a future readme update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants