Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use webmockr/vcr in tests #21

Closed
florianm opened this issue Aug 31, 2019 · 3 comments
Closed

Use webmockr/vcr in tests #21

florianm opened this issue Aug 31, 2019 · 3 comments
Assignees

Comments

@florianm
Copy link
Collaborator

Feature

Logging this idea for future Florian:
https://devguide.ropensci.org/building.html#recommended-scaffolding

This will make sense once ODK Central has reached 1.0 and development slows down.
Until then, ODK Central will add features to its API, and ruODK targets the latest ODK Central version (as indicated by mirroring the major/minor version numbers).

Suggestion: the best approach until 1.0 is to test the real deal and run tests uncached against the latest ODK Central instance run by ODK themselves. If those tests work, ruODK will be O(D)K.

@florianm florianm added this to the Release 1.0 milestone Aug 31, 2019
@florianm florianm self-assigned this Aug 31, 2019
@florianm florianm changed the title Once ODK Central has stabilised, use webmockr/vcr in tests Use webmockr/vcr in tests Sep 12, 2019
@florianm
Copy link
Collaborator Author

florianm commented Sep 12, 2019

@sckott says at ropensci/software-review#335 (comment)

I don't think the large size of the cassettes (cached http responses) affects r check, e.g., the cassettes directory in this package https://github.com/ropensci/rgbif/ is 32 MB, but running check on it throws no notes/warnings/etc - But i could be wrong - if size of cassettes is a concern, one option is to skip tests on CRAN for which cassettes are too large to include in the pkg, and those cassette files added to .Rbuildignore

@florianm
Copy link
Collaborator Author

Closing for now, good enough as is, discussion at ropensci/software-review#335.

@florianm
Copy link
Collaborator Author

florianm commented Dec 9, 2019

vcr bus is fixed, first test using vcr is passing! Gonna add more vcr goodness soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant