Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--upload-secrets does not honor SSH_USER, SSH_IDENTITY_FILE #22

Closed
sippeangelo opened this issue Nov 11, 2018 · 1 comment · Fixed by #24
Closed

--upload-secrets does not honor SSH_USER, SSH_IDENTITY_FILE #22

sippeangelo opened this issue Nov 11, 2018 · 1 comment · Fixed by #24
Assignees
@adamtulinius
Labels
bug Something isn't working enhancement New feature or request
Milestone
1.1

Comments

@sippeangelo
Copy link

The call to scp isn't passed the correct arguments to take SSH_USER and SSH_IDENTITY_FILE environment variables into account.

Since scp accepts the same arguments as ssh, the initialSSHArgs function should be able to be used just the same, with just a little reordering of the arguments.
@adamtulinius
Copy link
Contributor

@johanot Please assign this to yourself if you start working on it. I'll probably fix it tomorrow if you haven't by then.

@adamtulinius adamtulinius added bug Something isn't working enhancement New feature or request labels Nov 11, 2018
@adamtulinius adamtulinius self-assigned this Nov 12, 2018
adamtulinius added a commit that referenced this issue Nov 12, 2018
@adamtulinius
secrets: make scp honor SSH_USER and SSH_IDENTITY_FILE
c3f6d17 
This fixes #22
adamtulinius added a commit that referenced this issue Nov 12, 2018
@adamtulinius
secrets: make scp honor SSH_USER and SSH_IDENTITY_FILE
1c5e448 
This fixes #22
@adamtulinius adamtulinius mentioned this issue Nov 12, 2018
Merged
@adamtulinius adamtulinius added this to the 1.1 milestone Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamtulinius adamtulinius

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

Make scp honor SSH_IDENTITY_FILE and SSH_USER DBCDK/morph
2 participants
@sippeangelo @adamtulinius