Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --show-trace flag to morph and pass it to nix commands #44

Closed
johanot opened this issue Feb 18, 2019 · 0 comments · Fixed by #45
Closed

Add --show-trace flag to morph and pass it to nix commands #44

johanot opened this issue Feb 18, 2019 · 0 comments · Fixed by #45
Assignees
@johanot
Labels
enhancement New feature or request
Milestone
1.2

Comments

@johanot
Copy link
Contributor

johanot commented Feb 18, 2019

To better enable debugging, it should be possible to pass --show-trace to morph. --show-trace should then be passed through to both nix eval and nix build.
@johanot johanot added the enhancement New feature or request label Feb 18, 2019
@johanot johanot added this to the 1.2 milestone Feb 18, 2019
@johanot johanot self-assigned this Feb 18, 2019
johanot pushed a commit that referenced this issue Feb 18, 2019
Added --show-trace flag to morph
0866a32 
- Put eval-machines path and show trace option in a new struct called
NixContext for the purpose of minimising the number of flags we need to
pass to nix.GetMachines() and nix.BuildMachines() respectively.

- Deprecated the --build-arg flag, because.. it was introduced pretty
much only to be able to pass --show-trace, and it only works on "nix
build" anyway (not eval) with a lot of existing limitations.

fixes #44
@johanot johanot mentioned this issue Feb 18, 2019
Merged
adamtulinius pushed a commit that referenced this issue Feb 18, 2019
@adamtulinius
Added --show-trace flag to morph
29b975d 
- Put eval-machines path and show trace option in a new struct called
NixContext for the purpose of minimising the number of flags we need to
pass to nix.GetMachines() and nix.BuildMachines() respectively.

- Deprecated the --build-arg flag, because.. it was introduced pretty
much only to be able to pass --show-trace, and it only works on "nix
build" anyway (not eval) with a lot of existing limitations.

fixes #44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johanot johanot

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

Show trace flag DBCDK/morph
1 participant
@johanot