Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key binding to accept completion with the right-arrow key #165

Merged

Conversation

liamhennebury
Copy link
Contributor

Description

zsh-autosuggestions uses right-arrow to select a suggestion. I found that I end up hitting right-arrow often when using litecli. This change adds a key binding for right-arrow to accept a completion.

Checklist

  • I've added this contribution to the CHANGELOG.md file.

@@ -376,7 +376,7 @@ def test_auto_escaped_col_names(completer, complete_event):
Completion(text="id", start_position=0),
]
+ list(map(Completion, completer.functions))
+ [Completion(text="`select`", start_position=0)]
+ [Completion(text="select", start_position=0)]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-existing unit test failure, unrelated to change.

@amjith amjith merged commit fbaf48d into dbcli:main Sep 27, 2023
4 of 5 checks passed
@amjith
Copy link
Member

amjith commented Sep 27, 2023

Thank you!

@liamhennebury liamhennebury deleted the liamhennebury/right-arrow-completion branch September 27, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants