-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dbeaver/dbeaver#22103 replace autosave focus listener with dispose & tabbing support for datetime #22788
base: devel
Are you sure you want to change the base?
dbeaver/dbeaver#22103 replace autosave focus listener with dispose & tabbing support for datetime #22788
Conversation
Mac issue : if the cell is in edit mode and open any application or editor over the app, it becomes full screen 2024-02-13.14.56.04.mov |
value panel is not refreshed |
This case is broken again #10561 |
#22103-use-dispose-listener-for-autosave- Fixed focus for combo controls
#10561 broken on linux |
verified |
@@ -370,6 +374,9 @@ public void handleEvent(final Event event) { | |||
// we don't want to mess current grid state | |||
UIUtils.asyncExec(() -> presentation.navigateLink((GridCell) event.data, event.stateMask)); | |||
break; | |||
case SWT.MouseExit: | |||
System.out.println("Spreadsheet.handleEvent()"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Closes #22103
Removes hacky way of autosaving for Linux, so it should be tested #10561
Needs to be tested on MacOS and Linux
Focus listener is unfortunately not viable for supporting traverse inside the multi control composites, so it was replaced with dispose listener.
Test that all values save properly after inline editing