Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#29942 Fix dollar quote rule and postgre escape string rule #34393

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

E1izabeth
Copy link
Member

@E1izabeth E1izabeth commented Jun 19, 2024

If user uses dollar strings, then the settings should be set like this
image

With this settings now we correctly handle such cases (see foldings)
image

Script for testing

select
    format($x$%1$s$x$, 'foo'); 

select
    'bar';

select
    'baz';

DO $x$
BEGIN
	RAISE NOTICE '%', 'Test';
END $x$;


select 'zoo' 
from x
left join y on a=b
left join z on right(c,d)=0
where p>q

@E1izabeth E1izabeth linked an issue Jun 19, 2024 that may be closed by this pull request
@uslss
Copy link
Member

uslss commented Jun 28, 2024

verified

@serge-rider serge-rider merged commit 30f8d98 into devel Jun 28, 2024
4 checks passed
@E1izabeth E1izabeth deleted the #29942-sql-still-problematic branch July 3, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQL Still problematic
3 participants