mssql stored procedure implicit return value support

[javornikolov]

Add support for capturing procedure implicit return value (integer)

This is intended to resolve #351

[benilovj]

LGTM

[OB4]

Hello @benilovj, I got an runtime-error:

!|Execute Procedure|dbo.CalcLength_P|
|name|strlength?|?|

com.microsoft.sqlserver.jdbc.SQLServerException: Falsche Syntax in der Nähe des where-Schlüsselworts.
at com.microsoft.sqlserver.jdbc.SQLServerException.makeFromDatabaseError(SQLServerException.java:216)
at com.microsoft.sqlserver.jdbc.SQLServerStatement.getNextResult(SQLServerStatement.java:1522)
at com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement.doExecutePreparedStatement(SQLServerPreparedStatement.java:404)
at com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement$PrepStmtExecCmd.doExecute(SQLServerPreparedStatement.java:350)
at com.microsoft.sqlserver.jdbc.TDSCommand.execute(IOBuffer.java:5696)
at com.microsoft.sqlserver.jdbc.SQLServerConnection.executeCommand(SQLServerConnection.java:1716)
at com.microsoft.sqlserver.jdbc.SQLServerStatement.executeCommand(SQLServerStatement.java:180)
at com.microsoft.sqlserver.jdbc.SQLServerStatement.executeStatement(SQLServerStatement.java:155)
at com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement.executeQuery(SQLServerPreparedStatement.java:285)
at dbfit.environment.SqlServerEnvironment.readIntoParams(SqlServerEnvironment.java:92)
at dbfit.environment.SqlServerEnvironment.getAllProcedureParameters(SqlServerEnvironment.java:216)
at dbfit.api.DbStoredProcedure.getAllParams(DbStoredProcedure.java:57)
at dbfit.api.DbStoredProcedure.findAccessorForParamWithName(DbStoredProcedure.java:49)
at dbfit.api.DbStoredProcedure.getDbParameterAccessor(DbStoredProcedure.java:32)
at dbfit.fixture.DbObjectExecutionFixture.getAccessors(DbObjectExecutionFixture.java:121)
at dbfit.fixture.DbObjectExecutionFixture.getAccessors(DbObjectExecutionFixture.java:108)
at dbfit.fixture.DbObjectExecutionFixture.doRows(DbObjectExecutionFixture.java:71)
at fit.Fixture.doTable(Fixture.java:155)
at fitlibrary.traverse.AlienTraverseHandler.doTable(AlienTraverseHandler.java:18)
at fitlibrary.traverse.workflow.DoTraverseInterpreter.interpretWholeTable(DoTraverseInterpreter.java:99)
at fitlibrary.traverse.workflow.DoTraverseInterpreter.interpretWholeTable(DoTraverseInterpreter.java:87)
at fitlibrary.DoFixture.interpretWholeTable(DoFixture.java:69)
at fitlibrary.suite.InFlowPageRunner.run(InFlowPageRunner.java:34)
at fitlibrary.DoFixture.interpretTables(DoFixture.java:42)
at dbfit.DatabaseTest.interpretTables(DatabaseTest.java:26)
at fit.Fixture.doTables(Fixture.java:80)
at fit.FitServer.process(FitServer.java:81)
at fit.FitServer.run(FitServer.java:56)
at fit.FitServer.main(FitServer.java:41)

mika 4 0

[javornikolov]

Hi @OB4 - can you try the following query (sorry for the raw format - you need to strip + and "). The mistake should be somewhere in it:

                "select [name], [Type], max_length, is_output, is_cursor_ref from "
                    + "("
                    + "   select "
                    + "       p.[name], TYPE_NAME(p.system_type_id) as [Type], "
                    + "       p.max_length, p.is_output, p.is_cursor_ref, "
                    + "       p.parameter_id, 0 as set_id, p.object_id "
                    + "   from sys.parameters p "
                    + "   union all select "
                    + "        '' as [name], 'int' as [Type], "
                    + "        4 as max_length, 1 as [is_output], 0 as is_cursor_ref, "
                    + "        null as parameter_id, 1 as set_id, o.object_id "
                    + "   from sys.objects where type in (N'P', N'PC') "
                    + ") where object_id = OBJECT_ID(?) order by set_id, parameter_id");

[OB4]

Hallo @javornikolov, here his a screenshot from the query and the result:

[javornikolov]

Hi @OB4 - as far as I can see, you have added an AS u alias before where object_id = OBJECT_ID(?).
Does it fail without it? (If yes - maybe this was causing the error).

[OB4]

Hallo @javornikolov, yes indeed, without the alias the query fails.

[OB4]

Hallo @javornikolov, I have forgotten: in the union I droped the 'o' of 'o.object_id'

[javornikolov]

Hello @OB4, could you try this build and let us know if it works OK.