HSQLDB: allow mixed case table names in Insert/Update/Clean #356
Conversation
|
Also start to address #292. |
Would it be possible to pick that from some artifact repository? E.g. maybe from here: https://maven-repository.com/artifact/org.hsqldb/hsqldb/2.3.2 |
|
|
||
| import fitnesse.junit.FitNesseSuite; | ||
|
|
||
| import org.junit.Ignore; |
There was a problem hiding this comment.
Ignore annotation is not referenced below, no need to import it.
|
After removing the HSQL JAR from custom_libs and the gradle cache (at /home/vagrant/.gradle/...) the build then automatically pulls the JAR from |
|
One more option here - include the HSQL tests in the fastbuild task. As the current HSQL tests are using a memory only DB they run quickly. What do you think? |
👍 this is a good idea. The tests are much less likely to break this way. |
|
Yeah, I agree. I'm just running hsqldb tests locally - it's so quick, that I'm wondering whether it executed any test at all. I'm trying to verify... |
Verified - it's all working OK. @MMatten, could you squash your commits into a single one and force-push the branch (since most are just fix-ups, not so interesting history). And then we can merge the PR, looks good to me. |
|
Ok, will do. I think I should now also remove |
Yes |
MMatten
force-pushed
the
enable-hsql-tests
branch
from
0bf94a5
to
87147f8
Compare
| @@ -0,0 +1,20 @@ | |||
| package dbfit.environment; | |||
There was a problem hiding this comment.
looks like that file is with dos-style end of line
There was a problem hiding this comment.
I'd edited from Windows Eclipse but checked in from the VM and hadn't set autocrlf to input.
MMatten
force-pushed
the
enable-hsql-tests
branch
from
87147f8
to
2eb7000
Compare
|
One more commit to push in a minute - updating the main doc file. |
MMatten
force-pushed
the
enable-hsql-tests
branch
from
2eb7000
to
95db5af
Compare
Enable common test suite for HSQL. Correctly handle case sensitive object names. Add HSQLDB tests to fastbuild gradle task
MMatten
force-pushed
the
enable-hsql-tests
branch
from
95db5af
to
6071ef1
Compare
|
Right, final doc edits done. |
|
Awesome! I'm going to merge this PR. |
|
Great. Does this kill off #292? |
javornikolov
changed the title
This introduces the CoreTests for HSQL.
It also allows mixed case table names to be accessed by Insert/Update/Clean as HSQL converts unquoted names to upper case upon creation.
Tests are executed against a memory-only database to make set-up simpler but this might be better to start up a database as part of the VM provisioning so that the DDL for the CoreTests can be moved out of the SetUp.
hsqldb-2.3.2.jaris currently being pulled fromcustom_libs.Resolves #292