Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faraday::Error::ResourceNotFound Did you mean? Faraday::ResourceNotFound #79

Closed
Souravgoswami opened this issue Aug 31, 2020 · 5 comments
Closed

Faraday::Error::ResourceNotFound Did you mean? Faraday::ResourceNotFound #79

Souravgoswami opened this issue Aug 31, 2020 · 5 comments
Labels
confirmed bug

Comments

@Souravgoswami
Copy link

Hi, if I search for some term that doesn't exist, I get:

Faraday::Error::ResourceNotFound Did you mean? Faraday::ResourceNotFound

So Instead of rescuing Faraday::ResourceNotFound, I have to rescue NameError now.
@dblock
Copy link
Owner

dblock commented Aug 31, 2020

This is a Faraday versioning problem, either lock Faraday < 1, or upgrade the client to Faraday 1.0 similarly to dblock/open-weather-ruby-client#13. Want to give it a shot in a PR?

@Souravgoswami
Copy link
Author

I just wanted to send PR, but it's fixed before that... Thanks for the quick action!

@dblock
Copy link
Owner

dblock commented Sep 1, 2020

It's not fixed AFAIK, we didn't do anything.

@dblock
Copy link
Owner

dblock commented Sep 1, 2020

Oh I see, it was done part of #71, we just need to do a release.

@dblock dblock closed this as completed Sep 1, 2020
@dblock dblock mentioned this issue Sep 1, 2020
Closed
@dblock
Copy link
Owner

dblock commented Sep 1, 2020

I released 1.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dblock @Souravgoswami