Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the viaf.org script #7

Closed
m1ci opened this issue Apr 18, 2016 · 6 comments
Closed

fix the viaf.org script #7

m1ci opened this issue Apr 18, 2016 · 6 comments
Assignees
Labels

Comments

@m1ci
Copy link
Contributor

m1ci commented Apr 18, 2016

https://github.com/dbpedia/links/blob/master/links/dbpedia.org/viaf.org/scripts/makeLinks.sh

@kurzum kurzum modified the milestone: rpod Oct 18, 2016
@kurzum kurzum added the bug label Oct 25, 2016
@RPOD
Copy link
Contributor

RPOD commented Oct 31, 2016

Changed the resource link of the viaf.org script in 5b93cc1 which is reachable. However the script will download a 9.1GB zip file. Should this be changed or this much traffic acceptable?

@m1ci
Copy link
Contributor Author

m1ci commented Oct 31, 2016

I think 9GB is fine. Actually, we will always first need to approve a contribution, so I would not set some general requirement on the traffic, but decide on this at a contribution level.

@RPOD
Copy link
Contributor

RPOD commented Oct 31, 2016

What is the maximum size of a file? I would update the How To wiki page to insure that each contributor is aware of it and does not create scripts which generate an unnecessary amount of network traffic

@m1ci
Copy link
Contributor Author

m1ci commented Oct 31, 2016

for a maximum size of a file, please look at the current files and set the size maximum size to a number where most of the current linksets fit in. 0.5GB, 1GB? dont know. As a note you can write smth like: "If your linkset generation needs to download more the 1GB of data, please contact the maintainers." What do you think?

@RPOD
Copy link
Contributor

RPOD commented Oct 31, 2016

Sounds reasonable I will add that right away.

@kurzum
Copy link
Member

kurzum commented Nov 18, 2016

  1. users can provide a download link
  2. we can keep large stable files in http://downloads.dbpedia.org/links/resources/
  3. maximum file size should be 50MB that is already a lot to handle for Git, each change will be logged indefinitely, so if a 50mb file gets updated 10 times it is 500 through all revisions, which you need to fully download on git clone.

@kurzum kurzum closed this as completed Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants