-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the viaf.org script #7
Comments
Changed the resource link of the viaf.org script in 5b93cc1 which is reachable. However the script will download a 9.1GB zip file. Should this be changed or this much traffic acceptable? |
I think 9GB is fine. Actually, we will always first need to approve a contribution, so I would not set some general requirement on the traffic, but decide on this at a contribution level. |
What is the maximum size of a file? I would update the How To wiki page to insure that each contributor is aware of it and does not create scripts which generate an unnecessary amount of network traffic |
for a maximum size of a file, please look at the current files and set the size maximum size to a number where most of the current linksets fit in. 0.5GB, 1GB? dont know. As a note you can write smth like: "If your linkset generation needs to download more the 1GB of data, please contact the maintainers." What do you think? |
Sounds reasonable I will add that right away. |
|
https://github.com/dbpedia/links/blob/master/links/dbpedia.org/viaf.org/scripts/makeLinks.sh
The text was updated successfully, but these errors were encountered: