Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1452] gradoop store integration test suite #1462

Conversation

Rascat
Copy link

@Rascat Rascat commented Dec 10, 2019

Divides test methods in gradoop-store into unit and integration tests

Description

This PR adds Category annotations to JUnit tests, and and group annotations to testng tests.
In addition, it adds two new testng suit xml files to gradoop-hbase in order to enable the execution of either unit, or integration tests.
Also, the poms for gradoop-hbase and gradoop-accumulo are altered in such a way, that simply issuing mvn test will ONLY run the modules unit tests. The newly added integration profile needs to be added in order to run the integration tests IN ADDITION TO the unit tests.

Related Issue

fixes #1452

Motivation and Context

This change enables a faster development workflow. since it is not necessary to run integration test for every change made, these can now be skipped in a simple way. Still, by enabling the integration profile, integration tests are being run, which is important for verification or releases.

How Has This Been Tested?

I issues mvn test on the parent module and checked if only the unit tests were being executed. Then i issued mvn test -Pintegration and checked whether all the tests were being executed.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (if necessary).
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I ran a spell checker.

Lucas Schons added 5 commits November 26, 2019 14:11
Adds a new interface 'IntegrationTests' to gradoop-accumulo.
This interface is used to categorize every test class in the
module. The category is excluded from surefire execution.
…gration or

'unit'
  * Create two testng suite xml files to run either of the new groups
  * Configure surefire to only run unit tests
  * Add default profile in gradoop-accumulo pom to control exection of
  integration tests
  * Add integration profile to gradoop-hbase pom
  * fix typo
  * fix testng integration test suite name
Copy link
Collaborator

@p-f p-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  - Removes testng unit group (every test NOT belonging to the the
integration test group gets countet as unit test.
  - Removes unneeded testng xml suite files.
  - Adds new testng suite xml file "complete"
@galpha
Copy link
Contributor

galpha commented Jun 8, 2020

Since we encountered several problems using TestNG in combination with Flink 1.10.1 and test suites of hbase and accumulo, we only keep using TestNG in gradoop-commons.

@galpha galpha closed this Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Divide gradoop-store integration- and unit-tests into separate test suites
4 participants