[#1452] gradoop store integration test suite #1462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new interface 'IntegrationTests' to gradoop-accumulo. This interface is used to categorize every test class in the module. The category is excluded from surefire execution.
…gration or 'unit' * Create two testng suite xml files to run either of the new groups * Configure surefire to only run unit tests
* Add default profile in gradoop-accumulo pom to control exection of integration tests * Add integration profile to gradoop-hbase pom * fix typo
* fix testng integration test suite name
ChrizZz110
reviewed
Dec 17, 2019
.../gradoop-accumulo/src/test/java/org/gradoop/storage/impl/accumulo/AccumuloStoreTestBase.java
Show resolved
Hide resolved
- Removes testng unit group (every test NOT belonging to the the integration test group gets countet as unit test. - Removes unneeded testng xml suite files. - Adds new testng suite xml file "complete"
|
Since we encountered several problems using TestNG in combination with Flink 1.10.1 and test suites of hbase and accumulo, we only keep using TestNG in gradoop-commons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Divides test methods in gradoop-store into unit and integration tests
Description
This PR adds Category annotations to JUnit tests, and and group annotations to testng tests.
In addition, it adds two new testng suit xml files to gradoop-hbase in order to enable the execution of either unit, or integration tests.
Also, the poms for gradoop-hbase and gradoop-accumulo are altered in such a way, that simply issuing
mvn testwill ONLY run the modules unit tests. The newly addedintegrationprofile needs to be added in order to run the integration tests IN ADDITION TO the unit tests.Related Issue
fixes #1452
Motivation and Context
This change enables a faster development workflow. since it is not necessary to run integration test for every change made, these can now be skipped in a simple way. Still, by enabling the integration profile, integration tests are being run, which is important for verification or releases.
How Has This Been Tested?
I issues
mvn teston the parent module and checked if only the unit tests were being executed. Then i issuedmvn test -Pintegrationand checked whether all the tests were being executed.Types of Changes
Checklist: