Fix passing of producer args from SQL::Translator::Diff. #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the producer args are present for changed fields, but not for created tables. So changing the questionable default for the MySQL version in the MySQL producer results in a different SQL types depending if the field is a new or an existing table.
|
sorry for the delay, very much appreciate the PR! |
rabbiveesh
added a commit
that referenced
this pull request
Jul 8, 2022
This reverts commit ccbb34c.
rabbiveesh
added a commit
that referenced
this pull request
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the producer args are present for changed fields, but not for
created tables.
So changing the questionable default for the MySQL version in the MySQL
producer results in a different SQL types depending if the field is a new
or an existing table.