Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create RuntimeConfig fixture and refactor the current test to use it #10000

Closed
1 task done
Tracked by #9649
ChenyuLInx opened this issue Apr 22, 2024 · 0 comments · Fixed by #10242
Closed
1 task done
Tracked by #9649

Create RuntimeConfig fixture and refactor the current test to use it #10000

ChenyuLInx opened this issue Apr 22, 2024 · 0 comments · Fixed by #10242
Assignees
@QMalcolm

Comments

@ChenyuLInx
Copy link
Contributor

ChenyuLInx commented Apr 22, 2024 •
edited
Loading

Housekeeping

  • I am a maintainer of dbt-core

Short description

Runtime config is a major configuration holder that is being used by other parts of the codebase.Having creating the fixture would make it easier to create unit tests for other parts of the codebase

Acceptance criteria

  • There is a generic RuntimeConfig unit test fixture
  • rewrite test_runtime.py to use this test fixture
@ChenyuLInx ChenyuLInx mentioned this issue Apr 22, 2024
Open
@ChenyuLInx ChenyuLInx changed the title Create RuntimeConfig fixture and rewrite x test to use it Create RuntimeConfig fixture and refactor the current test to use it Apr 22, 2024
@QMalcolm QMalcolm mentioned this issue May 29, 2024
Merged
5 tasks
This was referenced Jun 4, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@QMalcolm QMalcolm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create RuntimeConfig fixture dbt-labs/dbt-core
2 participants
@QMalcolm @ChenyuLInx