Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-596] [Feature] Allow customization of seed materialization logic for table creation/insertion #5206

Closed
1 task done
adamantike opened this issue May 3, 2022 · 0 comments · Fixed by #5207
Closed
1 task done
Labels
enhancement New feature or request

Comments

@adamantike
Copy link
Contributor

Is this your first time opening an issue?

Describe the Feature

As described in dbt-labs/dbt-snowflake#112 (comment), plugins can't simply override the logic of seed materialization, regarding table creation/truncation/insertion, without copying the entire implementation.

To simplify that, we can move this following logic to a separate macro:

{{ create_table_sql }};
-- dbt seed --
{{ sql }}

Describe alternatives you've considered

No response

Who will this benefit?

This change will benefit dbt-snowflake, as explained in dbt-labs/dbt-snowflake#112 (comment), by avoiding the need of copying the entire seed materialization logic only to surround the table creation/insertion within a transaction.

Are you interested in contributing this feature?

No response

Anything else?

@adamantike adamantike added enhancement New feature or request triage labels May 3, 2022
@github-actions github-actions bot changed the title [Feature] Allow customization of seed materialization logic for table creation/insertion [CT-596] [Feature] Allow customization of seed materialization logic for table creation/insertion May 3, 2022
@iknox-fa iknox-fa removed the triage label May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants