Unit testing feature branch pull request #8411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michelle Ark <michelle.ark@dbtlabs.com>
gshank
requested review from
MichelleArk and
graciegoheen
and removed request for
aranke and
colin-rogers-dbt
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8411 +/- ##
==========================================
+ Coverage 86.76% 86.95% +0.19%
==========================================
Files 185 187 +2
Lines 24321 25020 +699
==========================================
+ Hits 21101 21756 +655
- Misses 3220 3264 +44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…-core into unit_testing_feature_branch
* Switch to using 'test' command instead of 'unit-test' * Remove old unit test * Put daff changes into task/test.py * changie * test_type:unit * Add unit test to build and make test * Select test_type:data * Add unit tets to test_graph_selector_methods.py * Fix fqn to incude path components * Update build test * Remove part of message in test_csv_fixtures.py that's different on Windows * Rename build test directory
| class TestRunner(CompileRunner): | ||
| _ANSI_ESCAPE = re.compile(r"\x1B(?:[@-Z\\-_]|\[[0-?]*[ -/]*[@-~])") |
Check warning
Code scanning / CodeQL
Overly permissive regular expression range Medium
| class TestRunner(CompileRunner): | ||
| _ANSI_ESCAPE = re.compile(r"\x1B(?:[@-Z\\-_]|\[[0-?]*[ -/]*[@-~])") |
Check warning
Code scanning / CodeQL
Overly permissive regular expression range Medium
* convert test to data_test * generate proto types * fixing tests * add tests * add more tests * test cleanup * WIP * fix graph * fix testing manifest * set resource type back to test and reset unique id * reset expected run results * cleanup * changie * modify to only look for tests under columns in schema files * stop using dashes
gshank
force-pushed
the
unit_testing_feature_branch
branch
2 times, most recently
from
5e98353
to
8fbbb65
Compare
gshank
force-pushed
the
unit_testing_feature_branch
branch
from
8fbbb65
to
56dfb34
Compare
MichelleArk
approved these changes
Jan 16, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #8283
This is a long-running feature branch pull request, used to merge main and verify that the current state is still working.
Checklist