Make fixtures files full-fledged members of manifest and enable partial parsing #9225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manifest.unit_tests
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## unit_testing_feature_branch #9225 +/- ##
===============================================================
+ Coverage 86.89% 86.90% +0.01%
===============================================================
Files 180 181 +1
Lines 27127 27236 +109
===============================================================
+ Hits 23572 23670 +98
- Misses 3555 3566 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MichelleArk
reviewed
Dec 6, 2023
| @@ -727,21 +727,21 @@ def search(self, included_nodes: Set[UniqueId], selector: str) -> Iterator[Uniqu | |||
|
|
|||
| manifest: WritableManifest = self.previous_state.manifest | |||
|
|
|||
| for node, real_node in self.all_nodes(included_nodes): | |||
| for unique_id, node in self.all_nodes(included_nodes): | |||
There was a problem hiding this comment.
thank you for renaming this here -- this has been bugging me forever!
MichelleArk
reviewed
Dec 6, 2023
|
This TODO in test_statecan also be cleaned up as part of this work! It should test the appropriate tests are selected when a file fixture is updated. |
MichelleArk
reviewed
Dec 6, 2023
emmyoop
approved these changes
Dec 7, 2023
core/dbt/parser/unit_tests.py
Outdated
| @@ -321,6 +316,58 @@ def _build_fqn(self, package_name, original_file_path, model_name, test_name): | |||
| fqn.append(test_name) | |||
| return fqn | |||
|
|
|||
| def _get_fixture(self, fixture_name: str, project_name: str): | |||
| fixture_unique_id = f"fixture.{project_name}.{fixture_name}" | |||
There was a problem hiding this comment.
Suggested change
| fixture_unique_id = f"fixture.{project_name}.{fixture_name}" | |
| fixture_unique_id = f"{NodeType.Fixture}.{project_name}.{fixture_name}" |
gshank
added a commit
that referenced
this pull request
Jan 16, 2024
* Initial implementation of unit testing (from pr #2911) Co-authored-by: Michelle Ark <michelle.ark@dbtlabs.com> * 8295 unit testing artifacts (#8477) * unit test config: tags & meta (#8565) * Add additional functional test for unit testing selection, artifacts, etc (#8639) * Enable inline csv format in unit testing (#8743) * Support unit testing incremental models (#8891) * update unit test key: unit -> unit-tests (#8988) * convert to use unit test name at top level key (#8966) * csv file fixtures (#9044) * Unit test support for `state:modified` and `--defer` (#9032) Co-authored-by: Michelle Ark <michelle.ark@dbtlabs.com> * Allow use of sources as unit testing inputs (#9059) * Use daff for diff formatting in unit testing (#8984) * Fix #8652: Use seed file from disk for unit testing if rows not specified in YAML config (#9064) Co-authored-by: Michelle Ark <MichelleArk@users.noreply.github.com> Fix #8652: Use seed value if rows not specified * Move unit testing to test and build commands (#9108) * Enable unit testing in non-root packages (#9184) * convert test to data_test (#9201) * Make fixtures files full-fledged members of manifest and enable partial parsing (#9225) * In build command run unit tests before models (#9273) --------- Co-authored-by: Michelle Ark <michelle.ark@dbtlabs.com> Co-authored-by: Michelle Ark <MichelleArk@users.noreply.github.com> Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com> Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> Co-authored-by: Kshitij Aranke <kshitij.aranke@dbtlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #9067
Problem
Because fixture files were not full-fledged SourceFiles and didn't have a representation in the manifest, we couldn't do partial parsing for fixture file changes.
Solution
Create a new source file class, FixtureSourceFile, and a lightweight UnitTestFixture node-like object in the manifest fixtures dictionary. Store the unique_ids of the fixtures and the related unit_tests in the source_file and process them in partial parsing.
Checklist