dbt-meshify split command, leaf nodes aren't made public when there are tests on the leaf nodes

[graciegoheen]

Describe the bug

I am trying to do this:

So I ran:

dbt-meshify split sales_analytics --select +int_sales__unioned +int_returns__unioned transactions

I would expect transactions to be made public (because it’s a leaf node), but it's not.

Steps to reproduce

• run dbt-meshify split on a selection of models that includes a leaf node

Expected results

• leaf node made public

Actual results

• lead node's access is unchanged

Screenshots and log output

System information

Which database are you using dbt with?

• postgres
• redshift
• bigquery
• snowflake
• other (specify: ____________)

The output of dbt debug:

<output goes here>

The output of dbt --version:

<output goes here>

Additional context

Are you interested in contributing the fix?

[dave-connors-3]

howdy grace 👽

I believe @nicholasyager tackled this in #102 !

1. I added a dummy leaf node to the split_proj project:

2. ran dbt-meshify --dry-run split test -s +orders dummy_leaf

3. Check out new project:

I think we should be good here!

[graciegoheen]

Hmm - I tried using my local dbt-meshify with the main branch and am still getting this bug:

• created a virtual environment
• pip installed dbt-core
• pip installed dbt-meshify
• navigated to my local dbt-meshify repo
• checked out the main branch
• git pull
• ran poetry install
• navigated to my example project
• ran dbt-meshify split sales_analytics --select +int_sales__unioned +int_returns__unioned transactions

And still, my transactions model (leaf node) does not have a contract not is it's access changed to public

[graciegoheen]

Looks like this may be because I currently have tests on my transactions model. When I remove the tests and re-run the command, transactions is made public and a contract is added.

[nicholasyager]

Looks like this may be because I currently have tests on my transactions model. When I remove the tests and re-run the command, transactions is made public and a contract is added.

Fantastic catch @graciegoheen! It sounds like we need to the graph grouping code to ignore test nodes as dependencies. Should be easy enough to resolve IMHO.