Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exposures do not play nice with meshify #191

Closed
dave-connors-3 opened this issue Dec 18, 2023 · 1 comment · Fixed by #194
Closed

exposures do not play nice with meshify #191

dave-connors-3 opened this issue Dec 18, 2023 · 1 comment · Fixed by #194
Assignees
Labels
bug Something isn't working
Milestone

Comments

@dave-connors-3
Copy link
Collaborator

Describe the bug

Report from a customer that exposures "break with meshify" -- this ticket is a stub to investigate. Hunch is that this is on the split operation

Additional context

Are you interested in contributing the fix?

@dave-connors-3 dave-connors-3 added bug Something isn't working triage Tis issue or pull request must be triaged by a project maintainer labels Dec 18, 2023
@graciegoheen graciegoheen added this to the 0.5.3 milestone Dec 18, 2023
@dave-connors-3
Copy link
Collaborator Author

Steps I took to test:

Add an exposure and split it with other models

  1. Add an exposure called crazy_growth_dashboard to the split project, dependent on only the orders model
  2. run dbt-meshify split dave_test --select "+orders exposure:crazy_growth_dashboard
  3. Result: ✅ -- everything moved as expected

Add an exposure and leave it behind

  1. Add an exposure called crazy_growth_dashboard to the split project, dependent on only the orders model
  2. run `dbt-meshify split dave_test --select +orders
  3. Result: ✅ -- everything moved as expected (even though the exposure is not dependent on models elsewhere)
  4. thought: perhaps this is the issue? that refs should be rewritten if you have an exposure now dependent on public model in another project?

@nicholasyager nicholasyager removed the triage Tis issue or pull request must be triaged by a project maintainer label Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants