-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Regression] Installing psycopg2-binary
instead of psycopg2
#50
Closed
2 tasks done
mikealfare opened this issue
Apr 4, 2024
· 1 comment
· Fixed by dbt-labs/dbt-core-bundles#139 or #60
Closed
2 tasks done
[Regression] Installing psycopg2-binary
instead of psycopg2
#50
mikealfare opened this issue
Apr 4, 2024
· 1 comment
· Fixed by dbt-labs/dbt-core-bundles#139 or #60
Comments
mikealfare
changed the title
[Regression] <title>
[Regression] Apr 4, 2024
psycopg2
version conflict
mikealfare
changed the title
[Regression]
[Regression] Installing Apr 4, 2024
psycopg2
version conflictpsycopg2-binary
instead of psycopg2
We need to update the bundle test to account for this. Re-opening to capture that work. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is this a regression?
Current Behavior
dbt-postgres>=1.8.0b2
is installingpsycopg2-binary
whenDBT_PSYCOPG2_NAME=psycopg2
and installing from PyPIExpected/Previous Behavior
dbt-postgres
should build usingpsycopg2
for all versions on PyPI when the environment variableDBT_PSYCOPG2_NAME=psycopg2
exists.Steps To Reproduce
Run:
Notice that
psycopg2-binary
is installed (in addition topsycopg2
). This happens even if the--no-binary dbt-postgres
flag is provided, which downloads the source distribution instead of the wheel.Environment
Additional Notes
Run:
DBT_PSYCOPG2_NAME=psycopg2 pip install "dbt-postgres @ git+https://www.github.com/dbt-labs/dbt-postgres.git" pip list
Notice that this installs
psycopg2
as expected, and notpsycopg2-binary
. We suspect that this has something to do with how thehatch
hook inhatch_build.py
with a distribution instead of building from source.Fixing this may also require and update to
dbt-core-bundles
to ensure bundles are building correctly.The text was updated successfully, but these errors were encountered: