Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAP-789] [Feature] Upgrade PyHive to support Python 3.11 #864

Closed
3 tasks done
JCZuurmond opened this issue Aug 9, 2023 · 5 comments · Fixed by #818
Closed
3 tasks done

[ADAP-789] [Feature] Upgrade PyHive to support Python 3.11 #864

JCZuurmond opened this issue Aug 9, 2023 · 5 comments · Fixed by #818
Labels
enhancement New feature or request triage xebia

Comments

@JCZuurmond
Copy link
Collaborator

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-spark functionality, rather than a Big Idea better suited to a discussion

Describe the feature

It looks like PyHive support Python 3.11 now. Let's investigate if we can use, so that dbt-spark can support Python 3.11.

Describe alternatives you've considered

N.a.

Who will this benefit?

Those who use Python 3.11

Are you interested in contributing this feature?

yes, other contributions are also welcome

Anything else?

No response

@JCZuurmond JCZuurmond added enhancement New feature or request triage xebia labels Aug 9, 2023
@github-actions github-actions bot changed the title [Feature] Upgrade PyHive to support Python 3.11 [ADAP-789] [Feature] Upgrade PyHive to support Python 3.11 Aug 9, 2023
@shishircc
Copy link

Thrift is only way I know dbt can work with EMR. Let me know if I am missing something here. The Thriftserver support would be crucial.

@leo-schick
Copy link

The issue here is related to the sasl package which does not work with python 3.11 anymore. To make this work, you need to install pyhive with extra hive_pure_sasl which uses pure-sasl instead of the sasl package. To make this work, dbt-spark should use pyhive[hive_pure_sasl] instead of just pyhive when installing dbt-spark[pyhive].

You can easily reproduce this issue by running pip install pyhive vs pip install pyhive[hive_pure_sasl] on a python 3.11 installation.

@dbeatty10
Copy link
Contributor

@JCZuurmond were you able to find out if @leo-schick suggestion works or not?

dbt-labs/dbt-core#9491 is currently blocked on this.

@JCZuurmond
Copy link
Collaborator Author

@dbeatty10 : I did not have time to verify this. Could you verify it and change the code accordingly?

@dbeatty10
Copy link
Contributor

@JCZuurmond good news: looks like this was resolved in #818

"PyHive[hive_pure_sasl]~=0.7.0",

pyhive[hive_pure_sasl]~=0.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage xebia
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants