Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spark, Presto, incremental strategy updates #77

Merged
merged 8 commits into from
Apr 3, 2020
Merged

Spark, Presto, incremental strategy updates #77

merged 8 commits into from
Apr 3, 2020

Conversation

jtcohen6
Copy link
Collaborator

@jtcohen6 jtcohen6 commented Apr 3, 2020 •
edited

Description & motivation

  • Update Presto profile (as of 0.15.3)
  • Update Spark profile (as of 0.15.3)
  • Add "Spark specific configurations" feature list
  • Move "Configuring incremental strategy" from Snowflake/BigQuery pages (duplicated) into "Configuring incremental models," with links back to Snowflake, BigQuery, and Spark specific configs

To-do before merge

  • Check relative links

@jtcohen6 jtcohen6 requested a review from drewbanin April 3, 2020 01:55
This was referenced Apr 3, 2020
Merged
Merged
drewbanin
drewbanin approved these changes Apr 3, 2020
View reviewed changes
Copy link
Collaborator

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great - all LGTM :)

@jtcohen6 jtcohen6 merged commit 85feb35 into master Apr 3, 2020
This was referenced Dec 13, 2023
Merged
Open
matthewshaver added a commit that referenced this pull request Dec 13, 2023
@matthewshaver
Ensure that the valid and default strategies are up-to-date and accur…
3b8ae01 
…ate per adapter (#4638)

resolves #4633


[Preview](https://docs-getdbt-com-git-dbeatty-update-incremental-4cfb6d-dbt-labs.vercel.app/docs/build/incremental-models#supported-incremental-strategies-by-adapter)

## What are you changing in this pull request and why?

- `merge` has been the default since [dbt-databricks
1.0.0](https://github.com/databricks/dbt-databricks/blob/7ad5507a8a38bde682bb28eb37466bbfc341ac94/CHANGELOG.md?plain=1#L404)
- For readability, removing references to "Delta only" since those were
added in [#77](#77)
(April 2020) and not updated since then to reflect additions of Hudi and
Iceberg
- Opened
[#4639](#4639) to
follow-up on the details

## 🎩 

<img width="450" alt="image"
src="https://github.com/dbt-labs/docs.getdbt.com/assets/44704949/016e098a-fc45-4841-9ce2-db2ad5049af5">

## Checklist
- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
so my content adheres to these guidelines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbanin drewbanin drewbanin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtcohen6 @drewbanin