Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the valid and default strategies are up-to-date and accurate per adapter #4633

Closed
1 task done
dbeatty10 opened this issue Dec 13, 2023 · 0 comments · Fixed by #4638
Closed
1 task done
Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear

Comments

@dbeatty10
Copy link
Contributor

dbeatty10 commented Dec 13, 2023

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

https://docs.getdbt.com/docs/build/incremental-models#supported-incremental-strategies-by-adapter

and each of the relevant adapter-specific config pages linked below.

What part(s) of the page would you like to see updated?

When #2895 was originally opened on 2023-02-20, I wrote the following:

I don't think they accurately reflect the current defaults and options -- I think there have been some updates since these were first published.

It would be good to determine if this has been resolved since then or if there is still anything outstanding.

Here's where to check the defaults in the base adapter:

And here's where to check in all the actual adapters:

Additional information

No response

@dbeatty10 dbeatty10 added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear labels Dec 13, 2023
matthewshaver added a commit that referenced this issue Dec 13, 2023
…ate per adapter (#4638)

resolves #4633


[Preview](https://docs-getdbt-com-git-dbeatty-update-incremental-4cfb6d-dbt-labs.vercel.app/docs/build/incremental-models#supported-incremental-strategies-by-adapter)

## What are you changing in this pull request and why?

- `merge` has been the default since [dbt-databricks
1.0.0](https://github.com/databricks/dbt-databricks/blob/7ad5507a8a38bde682bb28eb37466bbfc341ac94/CHANGELOG.md?plain=1#L404)
- For readability, removing references to "Delta only" since those were
added in [#77](#77)
(April 2020) and not updated since then to reflect additions of Hudi and
Iceberg
- Opened
[#4639](#4639) to
follow-up on the details

## 🎩 

<img width="450" alt="image"
src="https://github.com/dbt-labs/docs.getdbt.com/assets/44704949/016e098a-fc45-4841-9ce2-db2ad5049af5">

## Checklist
- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
so my content adheres to these guidelines.
matthewshaver added a commit that referenced this issue Dec 14, 2023
…ift (#4652)

resolves #4651

### Previews
- [dbt-postgres
configs](https://docs-getdbt-com-git-dbeatty-dynamic-default-pos-c89442-dbt-labs.vercel.app/reference/resource-configs/postgres-configs#incremental-materialization-strategies)
- [dbt-redshift
configs](https://docs-getdbt-com-git-dbeatty-dynamic-default-pos-c89442-dbt-labs.vercel.app/reference/resource-configs/redshift-configs#incremental-materialization-strategies)

## What are you changing in this pull request and why?

The default `incremental_strategy` for dbt-postgres and dbt-redshift is
dynamic!

It depends on [if `unique_key` is defined or
not](#4633):
- `delete_insert` when there is a unique_key defined and `append`
otherwise

All other adapters have a static default `incremental_strategy`.

## 🎩 

<img width="400" alt="image"
src="https://github.com/dbt-labs/docs.getdbt.com/assets/44704949/ba97b2cc-76e2-41d9-a8af-e1aeebb23a2d">

## Checklist
- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
so my content adheres to these guidelines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
1 participant