Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review docs for incremental_strategy for dbt-spark and dbt-databricks #4639

Open
1 task done
dbeatty10 opened this issue Dec 13, 2023 · 0 comments
Open
1 task done

Review docs for incremental_strategy for dbt-spark and dbt-databricks #4639

dbeatty10 opened this issue Dec 13, 2023 · 0 comments
Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear

Comments

@dbeatty10
Copy link
Contributor

dbeatty10 commented Dec 13, 2023 •
edited
Loading

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

Assess the following pages for accuracy and completeness in regards to incremental strategies:

What part(s) of the page would you like to see updated?

Assess if/how we should offer appropriate caveats based on endpoint or file format:

  • dbt-spark supports iceberg as a file format; does dbt-databricks also?
  • are all the relevant caveats included for which endpoints can be used with each incremental strategy?

Additional information

  • Caveats related to the incremental strategies usable with the Delta file format was added in #77 (April 2020), but it has not updated since then to reflect additions of Hudi and Iceberg. Caveats related to file format were removed in #4638 in favor of this issue.
  • dbt-spark and dbt-databricks allow the following combos of incremental strategy and file format (according to here):
    • merge may have delta or iceberg or hudi for file format (see here)
    • insert_overwrite is not allowed when connecting via endpoint (see here)
@dbeatty10 dbeatty10 added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear labels Dec 13, 2023
@dbeatty10 dbeatty10 mentioned this issue Dec 13, 2023
Merged
1 task
matthewshaver added a commit that referenced this issue Dec 13, 2023
@matthewshaver
Ensure that the valid and default strategies are up-to-date and accur…
3b8ae01 
…ate per adapter (#4638)

resolves #4633


[Preview](https://docs-getdbt-com-git-dbeatty-update-incremental-4cfb6d-dbt-labs.vercel.app/docs/build/incremental-models#supported-incremental-strategies-by-adapter)

## What are you changing in this pull request and why?

- `merge` has been the default since [dbt-databricks
1.0.0](https://github.com/databricks/dbt-databricks/blob/7ad5507a8a38bde682bb28eb37466bbfc341ac94/CHANGELOG.md?plain=1#L404)
- For readability, removing references to "Delta only" since those were
added in [#77](#77)
(April 2020) and not updated since then to reflect additions of Hudi and
Iceberg
- Opened
[#4639](#4639) to
follow-up on the details

## 🎩 

<img width="450" alt="image"
src="https://github.com/dbt-labs/docs.getdbt.com/assets/44704949/016e098a-fc45-4841-9ce2-db2ad5049af5">

## Checklist
- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
so my content adheres to these guidelines.
This was referenced Dec 14, 2023
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dbeatty10