Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsoo 3.0 #15

Closed
meadofpoetry opened this issue Aug 4, 2017 · 3 comments
Closed

jsoo 3.0 #15

meadofpoetry opened this issue Aug 4, 2017 · 3 comments

Comments

@meadofpoetry
Copy link
Contributor

At the moment Vg package conflicts with "js_of_ocaml" {>= "3.0"}. Could you upgrade the package to add jsoo.3.0 support please?
@dbuenzli
Copy link
Owner

dbuenzli commented Aug 4, 2017

It shouldn't be too hard, I think it's just that @hhugo changed the packaging structure in an undocumented manner which makes the build fail and I don't have the time to look into this at the moment. If you feel like giving it a look a PR would be welcome.

@dbuenzli
Copy link
Owner

dbuenzli commented Aug 8, 2017

The PR #16 doesn't work but it may be due to js_of_ocaml itself.

@dbuenzli
Copy link
Owner

dbuenzli commented Aug 8, 2017

Thanks to @Freyr666. This should be handled by ocaml/opam-repository#10056

@dbuenzli dbuenzli closed this as completed Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbuenzli @meadofpoetry