Make tracing an optional feature

[zeenix]

In GitLab by @bilelmoussaoui on Apr 26, 2023, 10:09

It ends up pulling tracing/ tracing-core / tracing-attributes indirectly. As in the libraries I wrote on top of zbus, I explicitly added a tracing feature, I would love if that feature would also control zbus's future tracing support.

[zeenix]

Sure, feel free to make it happen. :)

[zeenix]

@bilelmoussaoui this will unfortunately be a breaking change though for tokio users since they typically disable the default features. If we don't add this to the default features, then it breaks for everyone cause they now have to explicitly enabled it.

[bilelmoussaoui]

@bilelmoussaoui this will unfortunately be a breaking change though for tokio users since they typically disable the default features. If we don't add this to the default features, then it breaks for everyone cause they now have to explicitly enabled it.

I am ok with it being a default feature

[zeenix]

I am ok with it being a default feature

Yeah, of course but that doesn't help with the issue I described.

[REALERvolker1]

I decided to work on this a little bit today, but I ran into a problem with the tracing::instrument declarations. I made a reddit post asking for help. Basically I want to have instrumented functions, but I want the macro to expand into the attribute macro declaration. I plan on adding macros that expand into the tracing macros when the tracing feature is enabled, and macros that expand into nothing when it is disabled.

How does that sound?

[zeenix]

I decided to work on this a little bit today, but I ran into a problem with the tracing::instrument declarations. I made a reddit post asking for help. Basically I want to have instrumented functions, but I want the macro to expand into the attribute macro declaration. I plan on adding macros that expand into the tracing macros when the tracing feature is enabled, and macros that expand into nothing when it is disabled.

Thanks for taking it up. 👍

How does that sound?

Sounds good but the simpler/cleaner the solution, the better. The cfg_attr suggestion on Reddit, might be your best bet.