-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong types for some properties #1
Comments
I cannot reproduce... Can you provide your source code please? |
And does the player work properly? Is there a problem with volume or position? |
The player works properly. The problem is that client's cannot access Rate because it does not match the expected type. |
Can you check with the latest version please? I cannot reproduce with GNOME 3.16. |
I looked into this some time ago, as far as I understood, the problem is node-dbus and the way it tries to intelligently convert JavaScripts float64 into different types, which is happening here https://github.com/Shouqun/node-dbus/blob/master/src/encoder.cc#L28-52
eats all of your values, causing them to become type y in dbus. |
@PezaM , I noticed that you made some changes to the file you mentioned in node-dbus. Did you fix the issue? |
No, sorry, that doesn't fix the type y issue, fixed another one that occured before. Type y would take way more work than that |
I was going to open a new issue, however this one almost matches the description entirely. Currently facing a bug where the Metadata 'mpris:length' is expected to be an int64 (type x), but is currently marshalled to uint32. I've spent the better half of my morning diving into node-dbus only to figure out that the signal is only 'a{sv}', where v is the metadata object, and there's no way to provide signatures for each property in the metadata. Is this something you can see that would be fixable maybe via 'on the fly' instrospection? |
Seems that this code is here: https://github.com/Shouqun/node-dbus/blob/master/src/encoder.cc#L80 I really don't know how to do this :-( |
Yeah, I've opened an issue in that repo for this as well, and I thought we had solved it, but then I went to implement and it didn't work, which lead me to this issue. I'll explain what I found on that one over there and see if they might be able to troubleshoot some more. |
Has there been any progress on this? I can't get the position of my track because it's the wrong type. EDIT: @emersion the code in |
Migration to dbus-next (a fork of dbus-native) is a rewrite, but fixes some outstanding bugs in the project related to variant types. The project is now transpiled to use the experimental decorator feature that will be available in the language at some later time. gulpfile.js contains build instructions. Build with `npm run build`. The dist/ folder contains what will be published on npm. Interfaces are implemented as classes with decorators specifying the properties of the member that is exported on the bus. Update examples and add a new tracklist example. Other bugfixes may have been a side effect of the rewrite. fixes dbusjs#1 fixes dbusjs#6 fixes dbusjs#13
Migration to dbus-next (a fork of dbus-native) is a rewrite, but fixes some outstanding bugs in the project related to variant types. The project is now transpiled to use the experimental decorator feature that will be available in the language at some later time. gulpfile.js contains build instructions. Build with `npm run build`. The dist/ folder contains what will be published on npm. Interfaces are implemented as classes with decorators specifying the properties of the member that is exported on the bus. Update examples and add a new tracklist example. Other bugfixes may have been a side effect of the rewrite. fixes dbusjs#1 fixes dbusjs#6 fixes dbusjs#13
Using the latest version,
The text was updated successfully, but these errors were encountered: