Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dušan Vlahović's name being listed incorrectly / Scraper incorrectly handling š symbols #46

Closed
tvqt opened this issue Dec 9, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@tvqt
Copy link
Contributor

tvqt commented Dec 9, 2022

Hi there,

I was going through the data earlier, and I noticed Dušan Vlahović was being listed as "Du Scaron An Vlahović". On further investigation, that is how his name is written in his Transfermarkt URL, and the š symbol is known as a caron

@dcaribou
Copy link
Owner

FYI @tvqt

With this PR we should ve ready to solve this problem in the dataset repo. I'm moving the issue there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants