Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drawing commands and layout management should be centralized in a class #105

Closed
dccote opened this issue May 18, 2020 · 1 comment · Fixed by #232 or #307
Closed

Drawing commands and layout management should be centralized in a class #105

dccote opened this issue May 18, 2020 · 1 comment · Fixed by #232 or #307
Assignees
@dccote @JLBegin
Labels
before publication Critical to fix before we publish
Milestone
New layout manage...

Comments

@dccote
Copy link
Contributor

dccote commented May 18, 2020 •
edited
Loading

As much as possible, Matrix and other optical elements, ImagingPath and others should not be involved in layout details. Currently, for simplicity, elements "draw themselves" and MatrixGroups "display themselves". This is poor design.

We should be able to create a central class LayoutHelper that manages the layout (screen, paper, etc) and probably offers a simplified view of matplotlib drawing commands.
@dccote dccote added aesthetic No crash but looks ugly before publication Critical to fix before we publish labels May 18, 2020
@dccote dccote added this to the New layout manager implemented milestone May 18, 2020
@dccote dccote removed the aesthetic No crash but looks ugly label May 18, 2020
@dccote dccote linked a pull request Jun 1, 2020 that will close this issue
New FigureManager and Drawing API #215
Closed
@dccote dccote linked a pull request Jun 11, 2020 that will close this issue
Intermediate redesign of display #232
Merged
@dccote
Copy link
Contributor Author

dccote commented Jun 11, 2020

This has been partially done with the intermediate redesign.

@dccote dccote closed this as completed Jun 11, 2020
@dccote dccote reopened this Jun 11, 2020
@JLBegin JLBegin linked a pull request Jul 4, 2020 that will close this issue
New Figure API #307
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dccote dccote

@JLBegin JLBegin

Labels
before publication Critical to fix before we publish
Projects
None yet
Milestone
New layout manager implemented
2 participants
@dccote @JLBegin