You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you are not installing Python with Anaconda, it is important to keep tcl/tk support during python install since it is required by matplotlib's backend (tkinter). This is no problem if you follow default installation options.
Version compatibility
I tested RayTracing and it currently works on Python 3.6 and newer versions (3.7 & 3.8).
Since Python 3.5 is still an active Python 3 release, I tried to install RayTracing, but it fails to run because of a new type hint syntax for variable annotations (PEP 526) used in imagingpath.py:
I really want type hints. I suggest we recommend 3.6 and above, unless there are very good reasons to limit to 3.5.
Type hints are very important for educational purposes and clarity. It is one of the design goal, so we should not compromise on this considering it is only a minor version 3.5->3.6 requirement. I think we need to modify setup.py to reflect that.
RayTracing requires tkinter
If you are not installing Python with Anaconda, it is important to keep tcl/tk support during python install since it is required by matplotlib's backend (tkinter). This is no problem if you follow default installation options.
Version compatibility
I tested RayTracing and it currently works on Python 3.6 and newer versions (3.7 & 3.8).
Since Python 3.5 is still an active Python 3 release, I tried to install RayTracing, but it fails to run because of a new type hint syntax for variable annotations (PEP 526) used in imagingpath.py:
RayTracing/raytracing/imagingpath.py
Lines 87 to 88 in d6db956
I tested with the following edit on 3.5 which fixes the issue and works for 3.5+.
Conclusion
README.md
needs to be updated to tell the required python version.The text was updated successfully, but these errors were encountered: