Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CI Testing with Saucelabs #11

Merged
merged 4 commits into from May 7, 2015

Conversation

evilaliv3
Copy link
Contributor

This pull request implement support for testing scrypt-async-js in the cloud among multiple user browsers by means of SauceLabs.com.

@dchest: this cloud service is free for opensource projects and would be valuable to add it for scrpt-async so to properly validate the implementation against browsers setups.

Image used in the badge: https://saucelabs.com/browser-matrix/evilaliv3.svg
Readme.md badge viewable at: https://github.com/evilaliv3/scrypt-async-js/tree/feature/saucelabs

p.s. i've also removed the grunt-string-replace library that i included wrongly in previowu pull request

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.89% when pulling a2fa68f on evilaliv3:feature/saucelabs into 77d510b on dchest:master.

@dchest
Copy link
Owner

dchest commented May 5, 2015

Awesome, thanks! Do you think this can be fixed: https://travis-ci.org/dchest/scrypt-async-js/jobs/61231467#L326 ? Is this a timeout?

@evilaliv3
Copy link
Contributor Author

the internal code is the following:

        if (attempts === 0) {
          var errorMessage = "After trying " + me.statusCheckAttempts +
                             " times with a delay of " + me.pollInterval +
                             "s, this job never reached 'complete' status.";
          throw new Error(errorMessage);
        } else {
          return Q
            .delay(me.pollInterval)
            .then(fetch.bind(this, retries));
        }

so if i'm not wrong reading from https://github.com/axemclion/grunt-saucelabs the relevant wariables should be:

pollInterval: Number of milliseconds between each retry to see if a test is completed or not (default: 2000). Optional

statusCheckAttempts: Number of times to attempt to see if a test is completed or not (default: 90). Effectively, your tests have statusCheckAttempts * pollInterval seconds to complete (Thus, 180s by default). Set to -1 to try foreve

@dchest
Copy link
Owner

dchest commented May 6, 2015

@evilaliv3 will you set it or should I try?

@evilaliv3
Copy link
Contributor Author

ah! you were waiting for me!

sorry let me do it now.

@dchest
Copy link
Owner

dchest commented May 6, 2015

No hurry, I wasn't actually waiting for anything, was just busy with other things :-) Would be good if the CI build passes before I merge.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.89% when pulling 68fce80 on evilaliv3:feature/saucelabs into 77d510b on dchest:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.89% when pulling f0a1929 on evilaliv3:feature/saucelabs into 77d510b on dchest:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.89% when pulling d54fcaa on evilaliv3:feature/saucelabs into 77d510b on dchest:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.89% when pulling c96fd30 on evilaliv3:feature/saucelabs into 77d510b on dchest:master.

@evilaliv3
Copy link
Contributor Author

Ok @dchest i finally succeded.
i removed the specific test you put against node 0.10, 0.12 and iojs and i simply written "stable".
iojs was having issues to run the instrumented code. eventually we should differentiate but i think that now that we have real browser tests it is not required that we test against node as the libray is thought for the browsers.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.89% when pulling e016607 on evilaliv3:feature/saucelabs into 77d510b on dchest:master.

dchest added a commit that referenced this pull request May 7, 2015
Implement CI Testing with Saucelabs
@dchest dchest merged commit fbac994 into dchest:master May 7, 2015
@dchest
Copy link
Owner

dchest commented May 7, 2015

Yay, thank you!

@evilaliv3 evilaliv3 deleted the feature/saucelabs branch March 22, 2016 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants