Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export_key_jwk() doesn’t export canonical JSON #6

Closed
FGasper opened this issue Apr 25, 2016 · 2 comments
Closed

export_key_jwk() doesn’t export canonical JSON #6

FGasper opened this issue Apr 25, 2016 · 2 comments

Comments

@FGasper
Copy link
Contributor

FGasper commented Apr 25, 2016

For creating JWK thumbprints it’s necessary to have canonical (i.e., sorted keys) JSON.

The JWK that this module exports, being non-canonical, is useless, which means it’s necessary to parse the JSON, then re-encode it canonically.

It would help this purpose—without breaking any others—if this module exported JWKs as canonical JSON. Could this be done?
@karel-m
Copy link
Contributor

karel-m commented Apr 25, 2016

This one can be fixed quite easily - try 33a6c68

@karel-m
Copy link
Contributor

karel-m commented Apr 27, 2016

some tests added in 6991bd9

IMO fixed & ready for release

@FGasper FGasper closed this as completed Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FGasper @karel-m