Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace isalpha with isletter #53

Merged
merged 2 commits into from
Jul 21, 2018
Merged

Replace isalpha with isletter #53

merged 2 commits into from
Jul 21, 2018

Conversation

mlhetland
Copy link
Contributor

isalpha is deprecated.

`isalpha` is deprecated.
@coveralls
Copy link

coveralls commented Jul 19, 2018

Coverage Status

Coverage increased (+4.2%) to 78.859% when pulling 43c1071 on mlhetland:patch-1 into 48ec088 on dcjones:master.

@sglyon
Copy link
Collaborator

sglyon commented Jul 20, 2018

Thank you for doing this. I believe that this is a Julia 0.7 only feature. Perhaps there is a corresponding item in Compat.jl that would make this PR work on older versions of Julia also?

@mlhetland
Copy link
Contributor Author

Yes, Compat.jl adds isletter as an alias for isalpha, so it should still work.

@sglyon
Copy link
Collaborator

sglyon commented Jul 20, 2018

Ahh yes -- thanks for that. I had forgotten that we did a bare using Comat and that isletter would be brought into scope.

I think we need to set a minimum version bound on compat to ensure that users get a version of Compat that has isletter. Will you please add that to this PR?

@mlhetland
Copy link
Contributor Author

Updated REQUIRE now. There should be a Project.toml, too, to avoid warnings with 0.7 (and, eventually, problems with 1.x).

@sglyon
Copy link
Collaborator

sglyon commented Jul 21, 2018

Thank you!

yes, we need to construct a Project.toml for future julia. We will do that soon

I will merge this as is.

@sglyon sglyon merged commit b2f76ee into JuliaData:master Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants