Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rollback ref on unstyled link #864

Merged
merged 2 commits into from
Oct 25, 2022
Merged

fix: rollback ref on unstyled link #864

merged 2 commits into from
Oct 25, 2022

Conversation

vacas5
Copy link
Contributor

@vacas5 vacas5 commented Oct 25, 2022

Consuming LinkComponent has been a challenge downstream. We don't actually need the focus style manager to handle unstyled links as far as I can tell, so the console warnings should be resolved without having to keep drilling down into child Link components.

Description

Which issue(s) does this PR relate to?

Testing

Trade-offs

Screenshots

Checklist

  • If any new components were added, there are exported from packages/index.ts
  • This PR is associated with a JIRA and mentions in the commit message footer ("Closes …")
  • This PR contains breaking changes and states in the commit message body ("BREAKING CHANGE: …")
  • I have reviewed the changes and provided detail to the sections above

fix: rollback ref on unstyled link
32fb19a 
Consuming LinkComponent has been a challenge downstream. We don't
actually need the focus style manager to handle unstyled links as far as
I can tell, so the console warnings should be resolved without having to
keep drilling down into child Link components.
@vacas5 vacas5 requested a review from a team as a code owner October 25, 2022 20:52
nataliepina
nataliepina approved these changes Oct 25, 2022
View reviewed changes
Copy link
Collaborator

@nataliepina nataliepina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good on my part. I've tested with npm link and I didn't notice any console warnings. The stories all look to be working well. The implementation looks cleaner even. So it's a ✅ for me.

@vacas5 vacas5 merged commit 750d89d into main Oct 25, 2022
@vacas5 vacas5 deleted the randerson/fix/refs branch October 25, 2022 21:40
@github-actions
Copy link

🎉 This PR is included in version 11.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nataliepina nataliepina nataliepina approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vacas5 @nataliepina