Crash when exception during loading occurs #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timcharper
reviewed
Oct 4, 2018
| def load(context: Context): Application = { | ||
| val jobComponents = new JobComponents(context) | ||
|
|
||
| jobComponents.metricsModule.start(jobComponents.actorSystem) | ||
|
|
||
| Future { | ||
| jobComponents.schedulerService.run() | ||
| }(scala.concurrent.ExecutionContext.global) | ||
| }(scala.concurrent.ExecutionContext.global).onComplete { |
There was a problem hiding this comment.
Not related to your pull request, but I just realized how terrible this is. We're blocking one of the global execution contexts threads for the entire life of metronome, just so the scheduler service can have something to block?
There was a problem hiding this comment.
haha, good point, that's really not nice...
timcharper
approved these changes
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we were swallowing up these exceptions.
JIRA issues: DCOS_OSS-4239