Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import of collections.Hashable fails in Python 3.10 #79

Open
PTriebold opened this issue Oct 19, 2022 · 3 comments
Open

Import of collections.Hashable fails in Python 3.10 #79

PTriebold opened this issue Oct 19, 2022 · 3 comments

Comments

@PTriebold
Copy link

PTriebold commented Oct 19, 2022

System information

  • OS Platform and Distribution (e.g., Linux Ubuntu 16.04): macOS 12.6
  • Python version: 3.10.7
  • NumPy version: 1.23.3

Describe the current behavior
import of numpy_ml fails due to an ImportError with the collections module.

Describe the expected behavior
Importing just the module should not generate an ImportError

Code to reproduce the issue

# Python 3.10 or newer
import numpy_ml

Other info / logs
In Python 3.10 the deprecated aliases were removed.

Remove deprecated aliases to Collections Abstract Base Classes from the collections module. (Contributed by Victor Stinner in bpo-37324.)

from What’s New In Python 3.10

fix
To fix the bug, in /numpy_ml/utils/data_structures.py change

from collections import Hashable

to

from collections.abc import Hashable
@idanh
Copy link

idanh commented Feb 1, 2023

@ddbourgin any chance this will be fixed to support python 3.10? Thanks

@msf235
Copy link

msf235 commented Aug 5, 2023

@ddbourgin any chance this will be fixed to support python 3.10? Thanks

I created a pull request #85 to address this.

@chiarcos
Copy link

Could someone take a look at the pull request, maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants