Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot search lyrics for Up&Up - Coldplay #12

Closed
ddddxxx opened this issue Mar 30, 2017 · 0 comments
Closed

cannot search lyrics for Up&Up - Coldplay #12

ddddxxx opened this issue Mar 30, 2017 · 0 comments
Labels

Comments

@ddddxxx
Copy link
Owner

ddddxxx commented Mar 30, 2017

& is not a valid character

@ddddxxx ddddxxx added the bug label Mar 30, 2017
@ddddxxx ddddxxx closed this as completed in ad56eec May 3, 2017
ddddxxx added a commit that referenced this issue May 3, 2017
* dev:
  fix: search url unsafe characters failed, fix #12
  fix: disable translation in lyrics window when `prefer bilingual lyrics` is off fix #35
  feat: check for update automatically
  fix: surprising search result sorting
  feat: separate menubar icon and lyrics (#36
  localization
  fix: LyricsX crash while player is stopped, fix #25
ddddxxx added a commit that referenced this issue Jun 16, 2017
69f2bd0 limit concurrent operation for today extension
62d5c0e style...
02e9d67 add: id tag `re` and `ve`
9814cce update: binary search for locating lyrics line
ccd2903 fix: print metadata
ac84d5e refactor: lyrics model is class now
f9f87f6 style: no code changes
da2ec67 update: license
62aec1f add: GPL license
04c5c00 fix: search keyword will be percent encoded twice
5c9d9e2 fix: search url unsafe characters failed, fix #12
e98a304 fix: surprising search result sorting
c4b4e35 fix: call fetchCompleted multiple times
2a22055 refactor: lyrics source API fix #19
5417941 style: no code change
6fa23a7 style: no code change
abc25af refactor: use TimeInterval to present player position
b0b52e1 add: lyrics source Kugou
d7658bd fix: searching qq lyrics block main thread
71d2129 rename...
efede73 style: no code change
1f25cb3 style: no code change
8eb76a4 keep lyrics search result ordered
ff6749b remove: i feel lucky
04cea0a fix: overwrite metadata
5caef0c update: lyrics comparison
1a83459 update: store search result index in lyrics metadata
10312c2 fix: typo
1ac4a55 feat: use 163 lyrics by default
1f66ab7 update: security-scoped bookmarks for custom saving path
d0d814a remove LX- prefix
5f68baf feat: remove serial whitespaces
8f1a612 remove blank lyrics line
e9cc36c fix: decode escape characters in lyrics from QQMusic
9d79097 add: lyrics source QQMusic
fedc2fb update: lyrics replacement policy
f9468a0 fix: lyrics translation out of sync
d6e7b81 refactor: lyrics string transformer
8326d19 introduce EasyPreference
bbc3da4 lyrics translation
f1ecb64 break retain cycle
0aebee0 Add: Lyrics source 163
9bfb96b Use AMPathPopUpButton to choose lyrics saving path
aaa2d64 Add: Lyrics fetch completion callback
95d2167 Check title and artist when lyrics received
6dd7a82 Clean up
891cf02 current lyrics could be replaced by better one
04feb6a Process fetching result one by one

git-subtree-dir: LyricsX/Lyrics
git-subtree-split: 69f2bd082b01fb478672a2ed5a42b767f9ef8f39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant